[WIP] Add date format fallbacks #6667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
dhilst
force-pushed
the
date-format-fallbacks
branch
from
f150a2e
to
49d56b8
Compare
This was referenced Aug 25, 2024
dhilst
force-pushed
the
date-format-fallbacks
branch
2 times, most recently
from
70b912a
to
8da859d
Compare
dhilst
force-pushed
the
date-format-fallbacks
branch
5 times, most recently
from
85c1547
to
a860422
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
dhilst
force-pushed
the
date-format-fallbacks
branch
5 times, most recently
from
51ab733
to
5224337
Compare
|
GNU testsuite comparison: |
dhilst
commented
Aug 26, 2024
src/uu/date/src/parser.rs
Outdated
Comment on lines
199
to
206
| // Parse fallback for dates. It try to parse `input` and update | ||
| // `d` accordingly. | ||
| pub fn parse_fb( | ||
| input: &str, | ||
| d: DateTime<FixedOffset>, | ||
| ) -> Result<DateTime<FixedOffset>, (&str, parse_datetime::ParseDateTimeError)> { | ||
| Token::parse(input, d).map_err(|_| (input, parse_datetime::ParseDateTimeError::InvalidInput)) | ||
| } |
There was a problem hiding this comment.
I added this function, but afterward, I realized that parse_datetime is not a 3rd party library. I guess this should be fixed there instead of here!?
dhilst
force-pushed
the
date-format-fallbacks
branch
from
5224337
to
71c0305
Compare
|
GNU testsuite comparison: |
|
Continuing at: uutils/parse_datetime#86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds a date/parser.rs module with a fallback parser for failing dates.