Skip to content

Conversation

@cakebaker
Copy link
Contributor

This PR replaces a lot of run() calls in the tests with either succeeds() or fails() for better readability. It also fixes some small things I noticed while doing those replacements, for example, replacing .no_stdout().no_stderr() with .no_output().

@github-actions
Copy link

github-actions bot commented Mar 9, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

can we deprecate run() ? :)
(or make it private)

@sylvestre sylvestre merged commit 59af89e into uutils:main Mar 9, 2025
66 checks passed
@cakebaker cakebaker deleted the tests_replace_run branch March 10, 2025 06:06
@cakebaker
Copy link
Contributor Author

No, we still use it in tests, for example in test_chown.rs. There we suppress some failures if the tests are run in the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants