Skip to content

Conversation

@lukasx999
Copy link
Contributor

Removing the insertion of tabs instead of spaces when using the --classify or -F option seems to fix the mentioned issue. All of the tests pass, except for one, which obviously checks for tabs, which my fix changed.

It seems to me that the uutils_term_grid crate cannot properly align columns when using tabs as text.

With the fix, sometimes the alignment differs from the GNU implementation of ls, but I don't know how much of an issue that is.

fixes #7526

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/ls/stat-dtype. tests/ls/stat-dtype is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@emar-kar
Copy link
Contributor

Yeah, but this breaks #5396 , which required this change to be introduced

@cakebaker cakebaker changed the title fixed incorrect alignment when using --classify option ls: fixed incorrect alignment when using --classify option Mar 28, 2025
@sylvestre
Copy link
Contributor

is it still relevant ? thanks

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Apr 17, 2025

It's outdated due to #7616. Thanks for the contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ls --classify not wrapping lines correctly

4 participants