test_stat: Disable test_stdin_pipe_fifo1/2 on Mac OS X #7611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not totally clear why they sometimes work, sometimes fail, but it does appear that running `stat` on `/dev/stdin` is perhaps not the most reliable approach. A likely more solid approach is described in uutils#7583.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have been so flaky, sounds better to just disable for now. We can try to implement the fix documented in #7583 and re-enable at some point.
It's not totally clear why they sometimes work, sometimes fail, but it does appear that running
staton/dev/stdinis perhaps not the most reliable approach.A likely more solid approach is described in #7583.