-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
mkdir: add the selinux support #7635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a8d0d8 to
15bd763
Compare
|
interesting, it passed on my system but clearly fails here: |
|
the gnu tests don't pass for now but it is expected |
cakebaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I noticed is that GNU mkdir shows a warning if a context name is provided and the kernel doesn't support selinux whereas uutils mkdir doesn't:
$ mkdir somedir --context=testtest
mkdir: warning: ignoring --context; it requires an SELinux/SMACK-enabled kernel
$ echo $?
0
$ cargo run -q --features=selinux mkdir somedir --context=testtest
$ echo $?
0
a4a31f5 to
490e9c5
Compare
|
GNU testsuite comparison: |
490e9c5 to
588e1b3
Compare
|
@cakebaker |
588e1b3 to
81cb534
Compare
|
GNU testsuite comparison: |
81cb534 to
1b8ab85
Compare
|
GNU testsuite comparison: |
Should fix: gnu/tests/mkdir/selinux.sh tests/mkdir/restorecon.sh
|
@cakebaker i think it is now ready :) |
1b8ab85 to
fe77174
Compare
|
GNU testsuite comparison: |
No description provided.