printf: Error handling with unicode parsing #7681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargas
force-pushed
the
pass-printf-cov-test
branch
from
fbd4e0c to
c8328bc
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
c8328bc to
77cb93f
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
77cb93f to
3a1c17c
Compare
|
GNU testsuite comparison: |
RenjiSann
force-pushed
the
pass-printf-cov-test
branch
from
3a1c17c to
50ceac7
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
50ceac7 to
9aefd47
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
9aefd47 to
5f281ef
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
5f281ef to
fb74df2
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
fb74df2 to
92a194c
Compare
|
GNU testsuite comparison: |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
92a194c to
8c389b4
Compare
|
GNU testsuite comparison: |
Contributor
|
Could you please add a test in tests/by-util/test_printf.rs ? thanks |
sargas
force-pushed
the
pass-printf-cov-test
branch
from
8c389b4 to
7df2205
Compare
|
GNU testsuite comparison: |
Contributor
Author
Sure, I've pushed some tests for these changes |
jfinkels
approved these changes
Apr 12, 2025
Collaborator
jfinkels
left a comment
jfinkels
left a comment
There was a problem hiding this comment.
Congrats! The gnu test tests/printf/printf-cov is no longer failing!
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds error handling when
\uNNNNor\uNNNNNNis parsed. It also ignores the thousands seperator flag in format strings, which does not do anything for the "C" locale.This PR should allow GNU's printf-cov to pass.