Skip to content

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 8, 2025

A few minor linting changes:

  • simplify a few match statements
  • use .is_empty() instead of creating a new vector just to see if there is nothing in it
  • do not use std::u64 - use u64 keyword instead. Note that MAX is deprecated when used the old way.
  • remove mut in the &mut self for few functions that don't need it
  • remove unneeded casting

@sylvestre
Copy link
Contributor

Could you please update the commit message for something more explicit? Thanks

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@nyurik
Copy link
Contributor Author

nyurik commented Apr 8, 2025

@sylvestre I was a bit lazy, fixed it now :)

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit 6ea1f52 into uutils:main Apr 8, 2025
69 checks passed
@nyurik nyurik deleted the lints branch April 8, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants