feat: optimize dd parsing, bugfix
#7704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
nyurik
force-pushed
the
optimize-dd
branch
2 times, most recently
from
67a2db6 to
6c0e600
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
* Simplify param parsing in `dd` by using iterator instead of a slice * Fix two unit tests that appear to have a minor bug (?) - adding `iflag=<...>` instead of `oflag=<...>` during testing
|
GNU testsuite comparison: |
tertsdiepraam
approved these changes
Apr 14, 2025
Member
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Looks good! I like how the refactor solved the iflag/oflag confusion automatically.
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
feat: optimize `dd` parsing, bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddby using iterator instead of a sliceiflag=<...>instead ofoflag=<...>during testing