Fuzzing: minor fixes #7717
Merged
Fuzzing: minor fixes #7717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, cargo clippy fails when testing fuzz_seq_parse_number: ``` error[E0603]: module `number` is private --> fuzz_targets/fuzz_seq_parse_number.rs:9:13 | 9 | use uu_seq::number::PreciseNumber; | ^^^^^^ private module | note: the module `number` is defined here --> /home/drinkcat/dev/coreutils/coreutils/src/uu/seq/src/seq.rs:24:1 | 24 | mod number; | ^^^^^^^^^^ ``` But we can still fix the rest...
Just in case some of the values cause an infinite loop (or at least take a _very_ long time, see uutils#7708), timeout, with the same duration as the maximum total fuzzing time. That'll allow us to _see_ what input causes the infinite loop.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure what's the proper way to run
cargo clippyin fuzz, as it fails if I docd fuzz && cargo clippy.Let's fix what we can for now, we can think about how to add
fmt/clippytests to CI later (#7718).workflows/fuzzing.yml: Add timeout equal to total run time
Just in case some of the values cause an infinite loop (or at
least take a very long time, see #7708), timeout, with the same
duration as the maximum total fuzzing time.
That'll allow us to see what input causes the infinite loop.
fuzz: Run cargo clippy
Unfortunately, cargo clippy fails when testing fuzz_seq_parse_number:
But we can still fix the rest...
fuzz: Run cargo fmt