tail: Ignore a few tests on selinux #7756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_follow_when_files_are_pointing_to_same_relative_file_and_file_stays_same_size is flaky
sylvestre
commented
Apr 14, 2025
sylvestre
changed the title
sylvestre
commented
Apr 14, 2025
|
GNU testsuite comparison: |
Collaborator
|
The PR does exactly what it says. Hooray! However, I'm not convinced that skipping the test on SELinux is a good idea. After all, it seems that "follow" is inherently nondeterministic. So maybe we should change the test to accomodate for some spurious events, instead of disabling this test (and probably more tests in the future)? |
Contributor
Author
|
@BenWiederhake agreed but it will require time to do it and until then, we can disable them + open a new issue |
BenWiederhake
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_follow_when_files_are_pointing_to_same_relative_file_and_file_stays_same_size is flaky