tail: fix issue with -v flag and stdin #7792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue uutils#7613 Tail now correctly handles the -v flag when only 1 input file is given.
karlmcdowall
commented
Apr 19, 2025
| .set_stdin(File::open(at.plus("f")).unwrap()) | ||
| .arg("-v") | ||
| .succeeds() | ||
| .stdout_only("==> standard input <==\nfoo"); |
Contributor
Author
There was a problem hiding this comment.
Just to be clear, I've taken the existing test_stdin_redirect_file and split it into 2 separate tests - one test for the -v flag (which with this PR will now pass) and one test for the -f flag (which still fails, but is being tracked with a separate issue #7614).
karlmcdowall
commented
Apr 19, 2025
|
|
||
| settings.verbose = | ||
| settings.inputs.len() > 1 && !matches.get_flag(options::verbosity::QUIET); | ||
| settings.verbose = (matches.get_flag(options::verbosity::VERBOSE) |
Contributor
Author
There was a problem hiding this comment.
This basically reverts part of the change here 9b49f36
The reason this change got past our testing is that the relevant test was disabled at the time.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #7613
Tail now correctly handles the -v flag when only 1 input file is given.