Skip to content

Conversation

@cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Apr 24, 2025

This PR removes the test test_shred_verbose_pass_single_0_byte_name. It ensures that the 000000 pattern is used at least once within 200 iterations. A new test, test_all_patterns_present, introduced with #7830, ensures that each pattern is used at least once within 25 iterations, and thus covers the previous case, too.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit b7f2815 into uutils:main Apr 24, 2025
69 of 70 checks passed
@cakebaker cakebaker deleted the shred_remove_obsolete_test branch April 25, 2025 05:16
@BenWiederhake
Copy link
Collaborator

Awesome! I agree, test_all_patterns_present supersedes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants