uucore/echo:handle ControlFlow result #7881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit explicitly handles the result of the `write` function and allows an early stop when a `ControlFlow::Break` is received. It seems that currently only writing `EscapedChar::End` will trigger a break. In all other cases, `ControlFlow::Continue` is returned.
This commit analyzes the return value of the `write` function and stops the echo when a break is received. It allows: - simplifying the function's logic. Now, we don't rely on the item type and only analyze the return value. - avoiding compiler warnings about the unused `ControlFlow` result (nightly only). Since a break can only be triggered by `EscapedChar::End`, the old and new versions should be equivalent.
|
GNU testsuite comparison: |
Member
tertsdiepraam
left a comment
tertsdiepraam
left a comment
There was a problem hiding this comment.
Looks good, thanks! I confirmed that GNU echo indeed has this behaviour. Could you add a test for it?
Contributor
Author
|
@tertsdiepraam Thanks. I’ve added a test for the Ctrl-C sequence |
|
GNU testsuite comparison: |
RenjiSann
pushed a commit
to RenjiSann/coreutils
that referenced
this pull request
May 23, 2025
…ments uucore/echo:handle ControlFlow result
nickorlow
pushed a commit
to nickorlow/coreutils
that referenced
this pull request
Jul 17, 2025
…ments uucore/echo:handle ControlFlow result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Issue 7736
Hello Everyone,
This PR introduces analysis of returned
ControlFlowvalues, helping to eliminate compiler warnings about unused return values on nightly toolchains. It also adds the ability to exit early when encounteringEscapedCharacter::End, which seems like the correct behavior in that case. [1]While working on this, I noticed that the
printfutility already relies onControlFlowresults. So this change also helps unify the approaches and code betweenprintfandecho.Please note: these are initial changes, intended for review, discussion, and testing on real examples. Any feedback or observations are highly appreciated.
Thank you
[1] Output of GNU Coreutils (9.7) and uutils/coreutils
GNU coreutils
uutils/coreutils