shred: minor improvements and tests #7925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Contributor
|
I'm not sure about the test. Wouldn't it make more sense to assert the condition at compile-time? Something like: const _: () = assert!(OPTIMAL_IO_BLOCK_SIZE <= BLOCK_SIZE); |
Contributor
Author
|
Sounds good. I'll try. Thx |
The value of the variable remains unchanged (4096 = 2 ^ 12), but using a bitwise expression provides two benefits: - follows the same approach used for configuring BLOCK_SIZE - indicates that a power-of-two value is preferred for this kind of constant
This commit adds checks for block size constants. Misconfigured sizes could lead to overflows or performance issues. While such cases are expected to be rare or unlikely, it's better to be notified of them early.
alexs-sh
force-pushed
the
shred-minor-updates
branch
from
de863a7 to
14a8f3f
Compare
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is a minor improvement following the merge of #7915. It includes:
Thank you