Reenable windows-latest/x86_64-pc-windows-gnu (and do not update gcc) #7985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit deef8cb. A new onig release has happened, this should fix the issue.
The issue referenced has been long fixed, and for reasons not totally clear to me, blake3 fails after the GCC update (I tried to dig into this, but couldn't really figure out if this is really a problem with GCC 15, or with the version provided by MSYS, or some other side effect of the exact sequence in CI). Since blake3 CI doesn't do that gcc update (it uses the default gcc ~12 in the github windows image), let's _also_ not do that, and if there's a real problem with gcc 15+, that'll presumably fail their CI as well. Fixes uutils#7977.
|
GNU testsuite comparison: |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7977.
See commit message below, I don't fully get what's going on, but... I'm not sure how much that matters really (maybe something wrong with msys...).
We could have done that in the first place to avoid the onig issue... so this doesn't even need to be stacked on top of #7976.
.github/workflows/CICD.yml: Do not update gcc
The issue referenced has been long fixed, and for reasons not
totally clear to me, blake3 fails after the GCC update (I tried
to dig into this, but couldn't really figure out if this is really
a problem with GCC 15, or with the version provided by MSYS, or
some other side effect of the exact sequence in CI).
Since blake3 CI doesn't do that gcc update (it uses the default gcc ~12
in the github windows image), let's also not do that, and if there's a
real problem with gcc 15+, that'll presumably fail their CI as well.
Fixes #7977.
Revert "CICD: Disable windows-latest/x86_64-pc-windows-gnu for now"
This reverts commit deef8cb.
A new onig release has happened, this should fix the issue.