Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this patch fixes coreutils to compile on stable Rust by mostly following the recommendations given when removing the feature flags. In detail, that is:
fmt
s dependency onrustc_unicode
. It wasn't using it anyways.CharRange
usage fromfmt
and use the recommended handling methods (char_indices
andchars
). These methods recently got deprecated, see Tracking issue forstr_char
stabilization rust-lang/rust#27754, the struct is not committed to.tr
. The method is still under debate (Tracking issue for Read::chars rust-lang/rust#27802). As a buffered reader is used anyways, I concluded that we could just read into a buffer and work on that. I'm rather unsure if this patch is super-clean, it's a bit late. All tests pass and I think logically, it's alright, I'm just pretty sure it could be expressed neater.Best,
Florian, rust-community team