Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to stable #837

Merged
merged 4 commits into from
Mar 23, 2016
Merged

Move to stable #837

merged 4 commits into from
Mar 23, 2016

Conversation

skade
Copy link
Contributor

@skade skade commented Mar 22, 2016

Hi,

this patch fixes coreutils to compile on stable Rust by mostly following the recommendations given when removing the feature flags. In detail, that is:

  • remove fmts dependency on rustc_unicode. It wasn't using it anyways.
  • Remove CharRange usage from fmt and use the recommended handling methods (char_indices and chars). These methods recently got deprecated, see Tracking issue for str_char stabilization rust-lang/rust#27754, the struct is not committed to.
  • Remove usage of io::Read::chars() in tr. The method is still under debate (Tracking issue for Read::chars rust-lang/rust#27802). As a buffered reader is used anyways, I concluded that we could just read into a buffer and work on that. I'm rather unsure if this patch is super-clean, it's a bit late. All tests pass and I think logically, it's alright, I'm just pretty sure it could be expressed neater.

Best,
Florian, rust-community team

@jbcrail
Copy link
Contributor

jbcrail commented Mar 23, 2016

This looks great, and the code is clearer. 👍 Thanks!

@jbcrail jbcrail merged commit 9e50053 into uutils:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants