chore(deps): update rust crate xattr to v1.6.1 #8688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #8688 will create unknown performance changesComparing Summary
|
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
1.5.1->1.6.1Release Notes
Stebalien/xattr (xattr)
v1.6.1Compare Source
What's Changed
This release fixes a long-standing bug where we didn't correctly handle the return value of the FreeBSD and NetBSD xattr syscalls.
On Linux (and macOS), the xattr API returns ERANGE if the result doesn't fit in the provided buffer. On FreeBSD (and NetBSD), it returns the number of bytes read even if the syscall fails to read the entire value. This library assumed FreeBSD behaved the same as Linux.
In releases prior to 1.6.0, this issue was unlikely to be encountered in practice (except at scale) because we always checked the size before we read the attribute. It was still incorrect (TOCTOU issue), but it would have required a race with someone changing the extended attributes to trigger the bug.
In 1.6.0 this issue started showing up in testing because we try reading once with a 4KiB buffer before checking the size.
Full Changelog: Stebalien/xattr@v1.6.0...v1.6.1
v1.6.0Compare Source
What's Changed
Xattr can now read extended attribute values, list extended attributes, etc. in a single syscall instead of 2 as long as the total size is at most 4096 bytes. The downside of this change is that, e.g., if a file has more than 4KiB of extended attributes, listing extended attributes on the file will require 3 syscalls (because the first "optimistic" one will fail).
Full Changelog: Stebalien/xattr@v1.5.1...v1.6.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.