Skip to content

Conversation

@Ecordonnier
Copy link
Contributor

The make build was failing when the list of UTILS didn't contain stdbuf. This fixes this issue by adding feat_externa_libstdbuf only when stdbuf is being compiled.

Fixes #8701

@sylvestre
Copy link
Contributor

maybe add a github action test to make sure we don't regress ?

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 22, 2025

CodSpeed Performance Report

Merging #8702 will not alter performance

Comparing Ecordonnier:eco/makefile-stdbuf (873c376) with main (ea5c815)

Summary

✅ 75 untouched
⏩ 1 skipped1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@Ecordonnier Ecordonnier force-pushed the eco/makefile-stdbuf branch 2 times, most recently from 5b4a202 to 6fb6288 Compare September 22, 2025 08:50
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@Ecordonnier
Copy link
Contributor Author

maybe add a github action test to make sure we don't regress ?

Done

The make build was failing when the list of UTILS didn't contain stdbuf.
This fixes this issue by adding feat_externa_libstdbuf only when stdbuf is being compiled.

Fixes uutils#8701

Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 20c2779 into uutils:main Sep 26, 2025
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build with make fails with overriden UTILS

2 participants