-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
2 makefile fixes #8782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 makefile fixes #8782
Conversation
|
could you please add tests to make sure we don't regress? thanks |
c691c24 to
87455e6
Compare
|
GNU testsuite comparison: |
CodSpeed Performance ReportMerging #8782 will not alter performanceComparing Summary
Footnotes
|
87455e6 to
da20e91
Compare
|
GNU testsuite comparison: |
da20e91 to
065a9f2
Compare
|
GNU testsuite comparison: |
I added some test. Btw the busybox CI job failed because of some network issue and not because of this PR. |
065a9f2 to
702554a
Compare
|
GNU testsuite comparison: |
702554a to
ee61b8b
Compare
|
GNU testsuite comparison: |
This fixes this corner-case where SKIP_UTILS was not taken into account in the logic enabling feat_external_libstdbuf: ``` sudo make install SKIP_UTILS=stdbuf ... error: none of the selected packages contains this feature: feat_external_libstdbuf ``` Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
It is better to check whether we're actually compiling libstdbuf, rather than to check whether we're on windows, in order to decide whether libstdbuf should get installed. Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
ee61b8b to
159f5c8
Compare
|
GNU testsuite comparison: |
Commit 1:
Commit 2: