shred: ensure deterministic pass sequence compatibility with reference implementation #9317
+319
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
Contributor
sylvestre
force-pushed
the
shred-passes
branch
from
e3ac6d5 to
7d9a9ce
Compare
…e implementation should fix tests/shred/shred-passes.sh
sylvestre
force-pushed
the
shred-passes
branch
from
7d9a9ce to
4d5eed9
Compare
|
GNU testsuite comparison: |
cakebaker
reviewed
Nov 18, 2025
| }; | ||
|
|
||
| let random_source = match matches.get_one::<String>(options::RANDOM_SOURCE) { | ||
| let mut random_source = match matches.get_one::<String>(options::RANDOM_SOURCE) { |
Contributor
There was a problem hiding this comment.
Wouldn't it be simpler to store the path in RandomSource, instead of the file? It would allow you to keep random_source non-mutable.
I guess the todo on line 274 is now done with your changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix tests/shred/shred-passes.sh