tests.rs: Read executable binary location from environment at runtime #9323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Nov 18, 2025
| // Use the ctor attribute to run this function before any tests | ||
| #[ctor::ctor] | ||
| fn init() { | ||
| let cargo_bin_exe_location = |
Contributor
There was a problem hiding this comment.
maybe add a comment why we do that?
|
GNU testsuite comparison: |
This commit changes how the `CARGO_BIN_EXE_coreutils` environment variable is read. Previously, it was read using the `env!` macro, which returns the value of the variable as exposed by cargo during compilation. The problem with that is that it renders the process of testing for cross compiled targets, similar to what build systems like Yocto do, more difficult. The solution to this is to read said variable at runtime and if it is not defined, to default to the version offered by cargo. This way ensures that first of all, current functionality remains unchanged and that the code can be more easily cross compiled and tested in environments outside of cargo. Also, this commit closes uutils#9246 . Signed-off-by: Andreas Stergiopoulos <andreas.stergiopoulos@smile.fr>
andstepan
force-pushed
the
fix/read-bin-from-environment
branch
from
542ab53 to
2974bec
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how the
CARGO_BIN_EXE_coreutilsenvironment variable is read. Previously, it was read using theenv!macro, which returns the value of the variable as exposed by cargo during compilation.The problem with that is that it renders the process of testing for cross compiled targets, similar to what build systems like Yocto do, more difficult.
The solution to this is to read said variable at runtime and if it is not defined, to default to the version offered by cargo. This way ensures that first of all, current functionality remains unchanged and that the code can be more easily cross compiled and tested in environments outside of cargo.
Also, this commit closes #9246 .
@ycongal-smile