test(tail): fix flaky test_follow_name_multiple on macOS#9636
Open
naoNao89 wants to merge 2 commits intouutils:mainfrom
Open
test(tail): fix flaky test_follow_name_multiple on macOS#9636naoNao89 wants to merge 2 commits intouutils:mainfrom
naoNao89 wants to merge 2 commits intouutils:mainfrom
Conversation
CodSpeed Performance ReportMerging #9636 will degrade performances by 3.24%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
GNU testsuite comparison: |
Increase timeout from 500ms to 1300ms on macOS to account for file system caching delays when reading redirected output from temp files.
b365cab to
e02607d
Compare
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI: #9587 #9632
Fixes flaky test_follow_name_multiple by increasing timeout from 500ms to 3000ms on macOS.
Root cause: macOS FS caching delays output visibility when test framework reads redirected temp files.
https://github.com/uutils/coreutils/actions/runs/20132879326/job/57778876765
https://github.com/uutils/coreutils/actions/runs/20113818498/job/57718649405?pr=9629