Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial parts of automated compatibility tests #129

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Jan 21, 2022

This is the first half of the needed changes to set up automated
compatibility tests against GNU findutils and bfs, handling the uploads
of the build logs and JSON results. The workflow itself is heavily based
on the one from uutils/coreutils:

https://github.com/uutils/coreutils/blob/main/.github/workflows/GnuTests.yml

but with various cleanups & tweaks to better suit findutils.

This does not include the actual regression comparisons, because those
will only pass once archives of these files are up on the main branch.

Ref #128

Signed-off-by: Ryan Gonzalez ryan.gonzalez@collabora.com


Like the commit message mentions, this is the first half of the changes, because the second half needs already-built artifacts available. i.e., this needs to be merged first, then once CI passes, the second PR can be created and merged in.

I have tested these changes in a fork, you can see the results here:

I presume with this out of the way, I'll begin to see some of the open PRs merged? 😉 (Worth noting that, combining the current PRs with some offline work I have for -L, the amount of passing tests for BFS's suite goes up from the current 98 to 109!)

This is the first half of the needed changes to set up automated
compatibility tests against GNU findutils and bfs, handling the uploads
of the build logs and JSON results. The workflow itself is heavily based
on the one from uutils/coreutils:

https://github.com/uutils/coreutils/blob/main/.github/workflows/GnuTests.yml

but with various cleanups & tweaks to better suit findutils.

This does *not* include the actual regression comparisons, because those
will only pass once archives of these files are up on the main branch.

Ref uutils#128

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #129 (97ea4ae) into main (50d2bde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   49.80%   49.80%           
=======================================
  Files          19       19           
  Lines        2594     2594           
  Branches      702      702           
=======================================
  Hits         1292     1292           
  Misses       1046     1046           
  Partials      256      256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d2bde...97ea4ae. Read the comment docs.

@sylvestre
Copy link
Contributor

This is terrific, thanks :)

@sylvestre sylvestre merged commit 79d4bc4 into uutils:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants