Skip to content

shrink visibility of types/functions #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

yuankunzhang
Copy link
Contributor

No description provided.

@tertsdiepraam
Copy link
Member

tertsdiepraam commented May 19, 2025

I'll look at this in-depth later but note that this is mostly unnecessary because the modules these items are in are not public. I'm not really concerned with limiting visibility beyond the crate level in this crate. That mostly adds noise for a crate this small.

The same goes for the qualifiers on the fields. If a type is pub(crate) then pub on a field means the same thing as pub.

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (cc7c143) to head (c443685).

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #144   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuankunzhang yuankunzhang deleted the shrink-visibility branch May 21, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants