Handle panic while converting to Duration #20
Conversation
| @@ -157,7 +158,7 @@ pub fn from_str_at_date(date: NaiveDate, s: &str) -> Result<Duration, ParseDurat | |||
| is_ago = true; | |||
| } | |||
|
|
|||
| let duration = match unit { | |||
| let duration = panic::catch_unwind(|| match unit { | |||
There was a problem hiding this comment.
I think it is too broad
There was a problem hiding this comment.
probably second only
There was a problem hiding this comment.
Sorry, did you mean to catch panic only for case Duration::seconds ?
But it seems 8 out of the 11 case can cause panic when called with very high value.
One more thing, Should I remove the test case? It causes test failure in Basic:CI probably because of the option RUSTDOCFLAGS: -Cpanic=abort.
Thanks.
There was a problem hiding this comment.
@undali sorry but thinking more about this, it should probably done at the chrono level directly.
They should probably not panic when hitting this error
|
I agree with Sylvestre. |
To resolve #18