Use longest match during ACSL variable back-substitution #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gustavung thanks for this PR! Indeed a regression test would be nice to have! We should probably refactor the ACSL back-translator to not use a brittle string replacement at all, eventually. |
|
@gustavung I think it would be good to have this fix in TriCera even without any tests. I can land the PR if you give the green light. |
|
@gustavung I missed your thumbs up in my previous comment, so this PR was still sitting open, sorry for that! #10 eliminates the brittle string replacement used during back-translation, so I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have more than 10 variables to replace in the ACSL back-substitution, then e.g. _15 will be mistaken for _1. Suppose that our zipped seq is defined as:
{(x, 1),...,(y, _),...,(a, 15)}. This results in odd terms likex5 = yinstead ofa = y. The solution is to reverse the seq and make sure that we replace the longest matches first.I'll try to create a regression test next week.