Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pyqt6 and python 3.10 #119

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Support pyqt6 and python 3.10 #119

merged 4 commits into from
Jul 14, 2023

Conversation

StFroese
Copy link
Contributor

Unfortunately ViTables wasn't working on M1 Macs because PyQT5 wasn't installable.
I added PyQT6 and it seems to work no with python 3.10

@StFroese
Copy link
Contributor Author

@uvemas pls review :)

setup.py Outdated Show resolved Hide resolved
@StFroese
Copy link
Contributor Author

Should also work with python 3.11

@uvemas uvemas merged commit 8701517 into uvemas:master Jul 14, 2023
@uvemas
Copy link
Owner

uvemas commented Jul 14, 2023

Thanks a lot for your contrib @StFroese .

@StFroese
Copy link
Contributor Author

@uvemas no problem :)
Can we do a new release v3.0.3? I would then do a new conda release :)

@uvemas
Copy link
Owner

uvemas commented Jul 14, 2023

Sorry, I know that a new release is needed and that my project maintenance is really poor. But for now, it's all I can do, and I don't see this situation changing in the short term. Anyway, I'll try to be more active and work on a new release.

Thanks again for your help!

@StFroese
Copy link
Contributor Author

@uvemas I can also do the new release as an "as it is right now version". So would 3.0.3 would basically be support for python 3.10 and 3.11 as well as support for M1 Macs. I can open a PR, you just have to review :)

@JaRoSchm
Copy link

After my recent pull request to qtpy (spyder-ide/qtpy#440) this would also enable compatibility with PySide6 (new qtpy release needed too).

@uvemas
Copy link
Owner

uvemas commented Jul 14, 2023

Great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants