-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hake ML Update #84
Hake ML Update #84
Conversation
ctuguinay
commented
Mar 28, 2024
•
edited
Loading
edited
- Added workflow image
🚀 Deployed on https://deploy-preview-84--uw-echospace.netlify.app |
@valentina-s @leewujung Let me know what you think of these changes. I am still trying to figure out how to get rid of the aliasing here to improve image quality though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ctuguinay!
- Could you add a caption to the image (you can make it part of the image if it is easier so that it has a different font from the main text).
- To remove the aliasing, you should store in .png instead of .jpg, as jpg's algorithm is particularly bad at that.
- Also if you can use a different font for the packages: like the courier font, the names may stand out?
- I think the image can go after the discussion of the workflow.
- Could you add one more sentence after you mention the packages, that this allows us to organize data in a format suitable for deep learning and train models to predict regions of interest in echograms.
We could expand a bit on the content after that.
@valentina-s Thanks for the review! I incorporated your changes. Let me know if what I added to the pipeline makes sense or not. What I was trying to get with that addition was that Echopype and Echoregions transforms Echoview and Echosounder data into data products that can be used by many open-source repositories (ML repos just being one type of such repos), which is very powerful. |
@ctuguinay This image is still a low resolution. I tried to save at higher resolution from the slides. I also added reference to the NN diagram since it is not ours. Text looks good so feel free to merge once you get higher resolution image up (or if you do not have permissions let me know and I will merge). |
@ctuguinay could you update the image so we merge it. Thanks! |
@valentina-s I added your higher resolution image. I also didn't specify width and height and allowed the CSS to decide what to do with it in this case (specifying width and height distorted the image and if not wide enough, didn't fill up the column). I think this looks better, but what is displayed on the netlify deployment is still lower resolution since the image was resized to match the column width of the project page. |
I see, it looks ok when one zooms in. I think it is good enough for now! |
@valentina-s could you merge this if it's good? I don't have permissions to merge |
@ctuguinay I did not realize you did not have permissions. Merging now! |