Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hake ML Update #84

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Conversation

ctuguinay
Copy link

@ctuguinay ctuguinay commented Mar 28, 2024

  • Added workflow image

Copy link

github-actions bot commented Mar 28, 2024

@ctuguinay ctuguinay marked this pull request as ready for review March 28, 2024 22:56
@ctuguinay
Copy link
Author

@valentina-s @leewujung Let me know what you think of these changes. I am still trying to figure out how to get rid of the aliasing here to improve image quality though.

Copy link

@valentina-s valentina-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctuguinay!

  • Could you add a caption to the image (you can make it part of the image if it is easier so that it has a different font from the main text).
  • To remove the aliasing, you should store in .png instead of .jpg, as jpg's algorithm is particularly bad at that.
  • Also if you can use a different font for the packages: like the courier font, the names may stand out?
  • I think the image can go after the discussion of the workflow.
  • Could you add one more sentence after you mention the packages, that this allows us to organize data in a format suitable for deep learning and train models to predict regions of interest in echograms.
    We could expand a bit on the content after that.

@ctuguinay
Copy link
Author

@valentina-s Thanks for the review! I incorporated your changes. Let me know if what I added to the pipeline makes sense or not. What I was trying to get with that addition was that Echopype and Echoregions transforms Echoview and Echosounder data into data products that can be used by many open-source repositories (ML repos just being one type of such repos), which is very powerful.

@valentina-s
Copy link

valentina-s commented Apr 9, 2024

@ctuguinay This image is still a low resolution. I tried to save at higher resolution from the slides. I also added reference to the NN diagram since it is not ours.
See, if you like it. Also here is a link to the slides if you want to edit something: slide

featured

Text looks good so feel free to merge once you get higher resolution image up (or if you do not have permissions let me know and I will merge).

@valentina-s
Copy link

@ctuguinay could you update the image so we merge it. Thanks!

@ctuguinay
Copy link
Author

ctuguinay commented Apr 13, 2024

@valentina-s I added your higher resolution image. I also didn't specify width and height and allowed the CSS to decide what to do with it in this case (specifying width and height distorted the image and if not wide enough, didn't fill up the column). I think this looks better, but what is displayed on the netlify deployment is still lower resolution since the image was resized to match the column width of the project page.

@valentina-s
Copy link

I see, it looks ok when one zooms in. I think it is good enough for now!

@ctuguinay
Copy link
Author

@valentina-s could you merge this if it's good? I don't have permissions to merge

@valentina-s
Copy link

valentina-s commented Apr 26, 2024

@ctuguinay I did not realize you did not have permissions. Merging now!

@valentina-s valentina-s reopened this Apr 26, 2024
@valentina-s valentina-s merged commit 1d82c03 into uw-echospace:main Apr 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants