Aleaverfay/kinforest from stencil #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to build programmatically
Automated construction of both "id" and "parent" tensors now working properly.
The tricky part here is that we had to first construct the child_list and child_list_span tensors that describe the descendants of each atom so that we could then traverse up and down the parent tree and thus correct the frame_x, _y, and _z tensors. TO DO: replace bubble sort with mgpu's segmented sort to better handle cases where we might have a large number of descendants of a single node (e.g. the root!) but to still produce a deterministic kintree in spite of the non-determinism that the atomic-increment based ordering that I have currently.
… from restype stencils
Works for a single Pose in the PoseStack
…the fold tree spanning multiple blocks or perhaps multiple edges as "scan paths."
This corectly resets the "scans" offsets to 0 for the beginning of each generation. I believe this version should actually work for the forward pass. Here goes nothing!
…m/uw-ipd/tmol into aleaverfay/kinforest_from_stencil
…dule tests working
…jump_ff_edge_rooted_at_scan_path_seg
…/tmol into aleaverfay/kinforest_from_stencil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the beginning of a sketch of the algorithm to construct kintrees on the GPU using pre-computed per-residue kintrees and then integrating them all together.