Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 Core Update - updating base year to 2017 #45

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mitchphillipson
Copy link
Member

@mitchphillipson mitchphillipson commented Jun 6, 2024

With the full release of the BEA data for the years 1997 - 2022 we update our data.

You must download the updated core data from this link and place in your data/core directory. No other files in data/core are necessary.

@mitchphillipson mitchphillipson marked this pull request as ready for review June 6, 2024 14:25
Comment on lines +102 to +104
$echo theta_X_PD(r,g)$s0(r,g) = xd0(r,g)/s0(r,g); >>%gams.scrdir%MCPMODEL.GEN
$echo theta_X_PN(r,g)$s0(r,g) = xn0(r,g)/s0(r,g); >>%gams.scrdir%MCPMODEL.GEN
$echo theta_X_PFX(r,g)$s0(r,g) = (x0(r,g)-rx0(r,g))/s0(r,g); >>%gams.scrdir%MCPMODEL.GEN
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 5 zero values in s0, as seen below. The code smn is "Support activities for mining (213)".

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smn sector is a weird one for DC. It comes from being a byproduct of the mch sector (DC doesn't have any mining going on...). I found that removing tiny numbers helps and everything still solves.

fyr Years in FAF data (1997-2021),
* fyr(yr) Years in FAF data (1997-2022),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set the domain of faf_units to explicitly be yr in the data side. I've kept this to make minimal changes to the code, fyr is used below.

Comment on lines -69 to -73
$call 'csv2gdx ../data/core/faf_data_1997_2021.csv output=gdx/faf_data_1997_2021.gdx id=faf_units index="(1,2,3,4)" colCount=5 value=lastCol useHeader=Y';
$gdxin 'gdx/faf_data_1997_2021.gdx'
$load fyr=Dim4
$load faf_units
$gdxin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faf_units now gets loaded directly from windc_base.gdx

@andrewwschreiber
Copy link
Collaborator

Thanks, Mitch. I'll take a look today.

FYI -- I have more code that I think could be rolled into a future version, though obviously up to you and Tom, of the database on implementing the household disaggregation (making the cps/taxsim data calls be flexible based on user choice of income groups) and a sectoral disaggregation routine. I'll make another branch for that and tag you when its ready.

@andrewwschreiber
Copy link
Collaborator

Note to self: The get_cps.r code needs to be updated to grab data for 2022 (in both cps data grab and nipa data grab).

@andrewwschreiber
Copy link
Collaborator

andrewwschreiber commented Jun 11, 2024

The build now generates 2022 datasets through the household module. Made several changes to the household build:

  • updated hhcalib to reflect new data on wealth and expenditure distribution. also included an endogenized "other" category for transfers that reflects an additional degree of freedom when closing the budget constraint.
  • added dynamic household model
  • note that get_cps.r had to be updated to get new household data. I've sent that to you via email since the data subdirectory is included in .gitignore.

I have not had time to see whether the changes I've made in the household build carry through to the gtapwindc build. That still needs to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants