Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaaranan yaser annie/create volunteer signup implementation and interface #17

Conversation

vaaranan-y
Copy link
Contributor

@vaaranan-y vaaranan-y commented Nov 3, 2023

Notion ticket link

Ticket Name

Implementation description

  • Created skeleton code for interface and implementation of VolunteerSignUp Services (i.e. getVolunteerSignup, postVolunteerSignup, editVolunteerSignup)
  • Return types, implementation code, and parameter types to be added in next ticket

Steps to test

  1. Not really testable, however verification of function names and file definitions would be appreciated!

What should reviewers focus on?

  • Simply the definitions of the two files created for this ticket (do they match the standards of services we want to implement in this project)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@anmoltyagi1 anmoltyagi1 merged commit 79fab8e into master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants