Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admin Posting Details Page #167

Merged
merged 6 commits into from
Mar 1, 2022

Conversation

albertlai431
Copy link
Contributor

Ticket link

Closes #155

Implementation description

  • Refactored VolunteerPostingDetails page
  • Created routing for AdminPostingDetails page
  • Created query to fetch Posting data and the associated Admin Posting Details Page UI

Steps to test

  1. docker-compose up --build
  2. Navigate to http://localhost:3000/admin/posting/1 and verify that the UI matches that specified in Posting details page for schedule creation #155

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

Visit the preview URL for this PR (updated for commit 93bb27c):

https://sistering-dev--pr167-albert-posting-detai-3x69ep8l.web.app

(expires Tue, 08 Mar 2022 18:25:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing!

LenaNguyen
LenaNguyen previously approved these changes Feb 25, 2022
Copy link
Member

@LenaNguyen LenaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@albertlai431 albertlai431 merged commit 3248c7a into main Mar 1, 2022
@albertlai431 albertlai431 deleted the albert/posting-details-schedule-creation branch March 1, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posting details page for schedule creation
3 participants