New script to report isacc Communication resources as a CSV, per #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll note that the researchers are happy with the format of this csv |
Head comments to clarify usage.
Another comment, to clarify purpose.
|
@pbugni Can you please review this? I've just run it again against the prod systems, and added a few comments to the top to clarify purpose & usage. |
ivan-c
approved these changes
May 29, 2024
Comment on lines
+95
to
+116
| communication = entry['resource'] | ||
| communication_id = communication.get('id') | ||
| datetime = communication.get('sent') | ||
| type = extract_type(communication) | ||
| if type in ['isacc-comment', 'isacc-non-sms-message']: | ||
| recipient_reference = communication.get('subject', {}).get('reference') | ||
| else: | ||
| recipient_reference = communication.get('recipient', [{}])[0].get('reference') | ||
| if recipient_reference == None: | ||
| recipient_reference = communication.get('sender', {}).get('reference') | ||
| isacc_id = get_patient_isacc_id(recipient_reference, patient_cache) | ||
| content = communication.get('payload', [{}])[0].get('contentString') | ||
| if content: | ||
| content = content.replace('\n', '\\n') | ||
| sender = communication.get('sender', {}).get('reference') | ||
| if sender == None and type == 'isacc-auto-sent-message': | ||
| sender = 'system' | ||
| note = communication.get('note', [{}])[0].get('text') | ||
| if note: | ||
| note = note.replace('\n', '\\n') | ||
|
|
||
| writer.writerow([communication_id, datetime, recipient_reference, isacc_id, type, content, sender, note]) |
There was a problem hiding this comment.
might make sense to move the Communication processing/extraction to a separate function (and return a row/list), so it's easier to keep track of the fields of interest
Co-authored-by: Ivan Cvitkovic <ivanc@uw.edu>
Co-authored-by: Ivan Cvitkovic <ivanc@uw.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/186631379 .