Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TN-1773 Switch to python3 for packaged virtual environment #3352

Merged
merged 9 commits into from
Aug 2, 2019
Merged

TN-1773 Switch to python3 for packaged virtual environment #3352

merged 9 commits into from
Aug 2, 2019

Conversation

ivan-c
Copy link
Member

@ivan-c ivan-c commented Jul 10, 2019 •
edited
Loading

NB: python still maps to python2 as per debian policy

Todo:

Use new builtin venv module for creating debian-packaged virtual environment

@ivan-c ivan-c force-pushed the release/py3k-wip branch 4 times, most recently from cf8ee86 to 319776b Compare July 16, 2019 17:28
pbugni
pbugni reviewed Jul 16, 2019
View reviewed changes
Copy link
Collaborator

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - couple q's

bin/nodejs-wrapper.sh Outdated Show resolved Hide resolved
debian/portal.triggers Outdated Show resolved Hide resolved
@ivan-c ivan-c force-pushed the release/py3k-wip branch 2 times, most recently from 8646f88 to 319776b Compare July 16, 2019 22:49
@ivan-c ivan-c changed the title Switch to python3 for packaged venv Switch to python3 for packaged virtual environment Jul 16, 2019
@ivan-c ivan-c force-pushed the release/py3k-wip branch from 319776b to 7cc552c Compare July 16, 2019 23:37
@ivan-c ivan-c marked this pull request as ready for review July 16, 2019 23:39
@ivan-c ivan-c requested a review from pbugni July 16, 2019 23:39
@ivan-c ivan-c force-pushed the release/py3k-wip branch from 7cc552c to f865c72 Compare July 17, 2019 00:09
@ivan-c ivan-c changed the title Switch to python3 for packaged virtual environment TN-1773 Switch to python3 for packaged virtual environment Jul 17, 2019
pbugni
pbugni approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saweet!

ivan-c and others added 2 commits July 29, 2019 18:14
@ivan-c
Use python3 venv module for packaging (#3360)
d0758fe 
* Preinstall wheel module to squelch errors during package creation

* Use venv to build virtual environment with dh-virtualenv

* Use python builtin venv module to build venv

* Remove python2 test job

* Add local repo as trusted

* Remove past module references
@ivan-c
Merge branch 'develop' into release/py3k-wip
e47e3dc
@ivan-c ivan-c mentioned this pull request Jul 30, 2019
Merged
ivan-c and others added 3 commits July 30, 2019 09:17
@ivan-c
Update python version for debian buster
6314901
@ivan-c
Merge branch 'develop' into release/py3k-wip
dd30f85
@ivan-c
TN-1765 Remove shims; python2-only code (#3358)
37f28fe 
* Remove future shims

* Fixup py3 requirements

* Fix python3 metaclasses

* Remove python3 compat module

* Update sphinx docs ref to python3

* Update exception documentation to python3

* Sort imports

* Sort migration imports
@ivan-c ivan-c merged commit 0481bbf into develop Aug 2, 2019
@ivan-c ivan-c deleted the release/py3k-wip branch August 2, 2019 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorlima02 victorlima02 victorlima02 approved these changes

@pbugni pbugni pbugni approved these changes

@jhowe-uw jhowe-uw Awaiting requested review from jhowe-uw

@mcjustin mcjustin Awaiting requested review from mcjustin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivan-c @pbugni @victorlima02