Feature/wait for processed triggers #4393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbugni
approved these changes
Jul 18, 2024
| @@ -373,6 +373,12 @@ export default { /*global $ */ | |||
| setTimeout(function() { | |||
| this.getSubStudyTriggers(userId, params, callback); | |||
| }.bind(this), 1500*params.retryAttempt); | |||
| if (params.retryAttempt === params.maxTryAttempts) { | |||
| this.postAuditLog(userId, { | |||
| context: "access", | |||
There was a problem hiding this comment.
i don't see a great category in the audit/context column, but this isn't a controlled vocab.
perhaps "timeout" or "error" would make more sense. or stick with "assessment" as that's what is being collected here, so to speak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix based on Slack convo here
expand frontend retry attempts (will wait for at least 2 minutes and 35 seconds for the triggers to get processed)
add new hourglass indicator icon (see screenshot), the timing of sand dripping down to the end should coincides with the wait time
add audit logging for when Optout modal is presented, when Optout modal is dismissed, when maximum retry attempt is reached for retrieving triggers