Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test dependency #4404

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Update test dependency #4404

merged 3 commits into from
Sep 10, 2024

Conversation

ivan-c
Copy link
Member

@ivan-c ivan-c commented Sep 10, 2024

Workaround error during tests TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'

@ivan-c ivan-c changed the title Update packaging dependency Update test dependency Sep 10, 2024
@ivan-c ivan-c marked this pull request as ready for review September 10, 2024 19:39
@ivan-c ivan-c changed the base branch from develop to master September 10, 2024 19:39
@ivan-c ivan-c force-pushed the fixup/update-dependencies branch from c91d370 to 9f40963 Compare September 10, 2024 19:39
@pep8speaks
Copy link

pep8speaks commented Sep 10, 2024

Hello @ivan-c! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 785:5: E303 too many blank lines (2)

Comment last updated at 2024-09-10 19:40:25 UTC

@ivan-c ivan-c force-pushed the fixup/update-dependencies branch from 9f40963 to 4ade7cb Compare September 10, 2024 19:40
@ivan-c ivan-c force-pushed the fixup/update-dependencies branch from 4ade7cb to d18a2d7 Compare September 10, 2024 19:41
@ivan-c ivan-c requested a review from pbugni September 10, 2024 19:41
Copy link
Collaborator

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for the quick turn around.

@ivan-c ivan-c merged commit 84925bf into master Sep 10, 2024
2 checks passed
@ivan-c ivan-c deleted the fixup/update-dependencies branch September 10, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants