TN-3292 fix performance of patient list #4408

achen2401 · 2024-09-26T23:57:03Z

TN-3292, enhance performance of patients list, by moving to server-side pagination. Each respective page now requested via ajax

… same trigger

…o generate a JSON struct of a page worth of patients per ajax call.

pep8speaks · 2024-10-01T00:45:20Z

Hello @achen2401! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/migrations/versions/038a1a5f4218_.py:

Line 20:5: E128 continuation line under-indented for visual indent
Line 21:5: E122 continuation line missing indentation or outdented
Line 22:5: E122 continuation line missing indentation or outdented
Line 23:5: E122 continuation line missing indentation or outdented
Line 24:5: E122 continuation line missing indentation or outdented
Line 25:5: E122 continuation line missing indentation or outdented
Line 26:5: E122 continuation line missing indentation or outdented
Line 27:5: E122 continuation line missing indentation or outdented
Line 28:5: E122 continuation line missing indentation or outdented
Line 29:5: E122 continuation line missing indentation or outdented
Line 30:5: E122 continuation line missing indentation or outdented
Line 31:5: E122 continuation line missing indentation or outdented
Line 32:5: E122 continuation line missing indentation or outdented
Line 33:5: E122 continuation line missing indentation or outdented
Line 34:5: E122 continuation line missing indentation or outdented
Line 35:5: E122 continuation line missing indentation or outdented
Line 36:5: E122 continuation line missing indentation or outdented
Line 37:5: E122 continuation line missing indentation or outdented
Line 38:5: E122 continuation line missing indentation or outdented
Line 39:5: E122 continuation line missing indentation or outdented
Line 40:5: E122 continuation line missing indentation or outdented
Line 42:101: E501 line too long (105 > 100 characters)
Line 45:101: E501 line too long (103 > 100 characters)
Line 47:101: E501 line too long (115 > 100 characters)
Line 48:101: E501 line too long (105 > 100 characters)
Line 49:101: E501 line too long (103 > 100 characters)
Line 53:101: E501 line too long (121 > 100 characters)

In the file portal/migrations/versions/5a300be640fb_.py:

Line 25:16: E128 continuation line under-indented for visual indent
Line 26:16: E128 continuation line under-indented for visual indent
Line 36:101: E501 line too long (107 > 100 characters)
Line 47:101: E501 line too long (108 > 100 characters)
Line 50:16: E128 continuation line under-indented for visual indent
Line 51:16: E128 continuation line under-indented for visual indent

Comment last updated at 2024-10-09 23:43:11 UTC

…eted` patients.

consent date

…quest.

… data-fields for cleaner code.

…t_list

…/true_nth_usa_portal into feature/fast-patient-list

…ll drop-down columns.

…atient purge from functioning (see TN-3286)

… into feature/fast-patient-list

…ve recursion guard after demographic updates on patient_list

…f patient_list

ivan-c

Looks great, thanks for keeping the tests working!!

Amy Chen and others added 5 commits September 26, 2024 16:55

fix patient list table options to retrieve data via ajax

8fa52d1

fix call, remove fields

4e16ae8

New table and migration for paginated view of /patients

2ef425d

Keep patient_list in sync, updating whenever adherence_cache gets the…

227e60d

… same trigger

initial (very basic! missing lots) implementation of /patients/page t…

b0876e8

…o generate a JSON struct of a page worth of patients per ajax call.

pbugni and others added 24 commits October 1, 2024 09:46

populate data.rows from SQLA row object (not as simple as i had hoped).

33a42a4

fix template

9270389

populate table with ajax data, bug fix

cc4ebe0

add a job to pick up all deleted users when building patient list

b5d6a8a

remove obsolete code. patch check for include_test_role

c390571

allow null and non-unique email in patient_list, as required for `del…

25d2532

…eted` patients.

fix deleted account rows

6ca5b98

format date

043689a

populate remaining columns for global study in patient list

7d6d8d8

populate remaining columns for global study in patient list

9571dbb

filter patient list by organization filter.

a11cb42

must cast query string param to int!

fe5a478

fix org column, pass research study id, code clean up

09e91a1

put userid column back

3b93bfd

allow userid field to be searchable, remove search fields for dob and

d761015

consent date

implement search in patient list

cb5a389

implement order by column and direction

96baffd

fix column selection & filter displays

9c802fb

look to db table_preferences if sort & filter args aren't found in re…

dc8ac82

…quest.

fix empro field names, remove un-needed fields

d873338

add EMPRO data; all fields renamed in patient_list to match front end…

86327b8

… data-fields for cleaner code.

fix sort by id issue

7a6e499

fix patient list table options to retrieve data via ajax

f8d0068

fix call, remove fields

8a3291d

pbugni and others added 22 commits October 4, 2024 16:49

included _untranslated versions of all translated columns in patien…

14bd71f

…t_list

update patient_list cache on demographics change

e5a3a4c

don't allow non-patients to sneak into patient_list

febce33

fix filter select lists

2dcbf9b

Merge branch 'feature/fast-patient-list' of https://github.com/uwcirg…

157801f

…/true_nth_usa_portal into feature/fast-patient-list

Update admin_base.html - remove loader code

209ae40

Update admin.js - remove buggy code

e61035f

filter bug fixes

aab4709

fix retry attempts

2cbcf47

include all "options" with both translated and english versions for a…

d05fb72

…ll drop-down columns.

use filter option list from backend

c9fb633

update patient_list for freshly deleted patients.

ea45f61

bug fix, remove debug statement

aac7eff

add debouncing

4f4d77d

add missing ondelete='cascade' clauses to foreign keys preventing p…

8124b16

…atient purge from functioning (see TN-3286)

add missing ondelete='cascade' clauses to foreign keys preventing p…

e4462df

…atient purge from functioning (see TN-3286)

Merge branch 'develop' of https://github.com/uwcirg/true_nth_usa_portal…

176dfc7

… into feature/fast-patient-list

as user demographics changes frequently come in one after another, mo…

35fa2cc

…ve recursion guard after demographic updates on patient_list

code cleanup

bb0e7b8

fix loader style

fdc2cc3

remove un-used code

f190c17

need to commit changes on early exit from patient_list update!

2d7088e

pbugni requested a review from ivan-c October 9, 2024 20:25

pbugni marked this pull request as ready for review October 9, 2024 20:25

pbugni added 3 commits October 9, 2024 13:54

remove test failing, as the intervention column is no longer a part o…

907ade4

…f patient_list

pep8

2e187c3

missed a reuse of an existing foreign key constraint during development.

1328a09

ivan-c approved these changes Oct 10, 2024

View reviewed changes

ivan-c merged commit 1a3fb85 into develop Oct 10, 2024
2 checks passed

ivan-c deleted the feature/fast-patient-list branch October 10, 2024 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TN-3292 fix performance of patient list #4408

TN-3292 fix performance of patient list #4408

achen2401 commented Sep 26, 2024 •

edited by pbugni

Loading

pep8speaks commented Oct 1, 2024 •

edited

Loading

ivan-c left a comment

TN-3292 fix performance of patient list #4408

TN-3292 fix performance of patient list #4408

Conversation

achen2401 commented Sep 26, 2024 • edited by pbugni Loading

pep8speaks commented Oct 1, 2024 • edited Loading

Comment last updated at 2024-10-09 23:43:11 UTC

ivan-c left a comment

Choose a reason for hiding this comment

achen2401 commented Sep 26, 2024 •

edited by pbugni

Loading

pep8speaks commented Oct 1, 2024 •

edited

Loading