fix frontend error handing of patient list ajax error #4413
Conversation
Release v24.10.10
Address a stream of 400 errors (CSRF token is missing) related to saving patientlist table preferences. Cause: I think the error stemmed from when an ajax request was first made to retrieve patient data, which is precedes by a call to save table preferences, the document DOM was not ready (which includes the value of CSRF token in an hidden element) - hence the missing CSRF token error. Fix: To add check for DOM readiness before the request to save table preferences is made. --------- Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
Thanks @achen2401 . In your screenshot, it looks like the user wouldn't be able to clear the birthdate filter, which was the one causing the problem at https://movember.atlassian.net/browse/TN-3324 . I think this change would still be an improvement if that's the case, but I just want to clarify. |
@pbugni right, the user won't be able to clear the birthdate filter, but can see that error has occurred. This is an improvement, as the user can then try to clear other filter(s) (in the case of the screenshot, the study ID field), then the patient list data will be returned since the filters have been modified. |
This reverts commit 461afea.
accidentally merged [this](#4413) into Master, reverted that. Will merge this into the `develop` branch. Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
part of https://movember.atlassian.net/browse/TN-3324
Currently UI is a blank screen when the ajax call to retrieve patient list data encounters error:
Added fix to error handling with error displaying on screen and allowing user to change/clear filters on the UI if need to
