DuckDB doesn’t preserve IO Error, let us try to intercept DuckDBFailure

uwdata · Nov 18, 2024 · e010a50 · e010a50
1 parent c6ee2c1
commit e010a50
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/packages/duckdb-server-rust/src/query.rs b/packages/duckdb-server-rust/src/query.rs
@@ -1,5 +1,4 @@
 use std::future::Future;
-use std::io;
 use std::path::{Path, PathBuf};
 use std::pin::Pin;
 
@@ -29,19 +28,19 @@ where
         match query_fn(state, params.clone()).await {
             Ok(response) => return Ok(response),
             Err(AppError::Error(err)) => {
-                // Check if the error is an IO error
-                if let Some(io_err) = err.downcast_ref::<io::Error>() {
-                    if attempt <= max_retries {
+                if let Some(duckdb_err) = err.downcast_ref::<duckdb::Error>() {
+                    if matches!(duckdb_err, duckdb::Error::DuckDBFailure(_, _)) && attempt <= max_retries {
                         tracing::warn!(
-                            "IO error encountered: {}. Retrying after recreating connection. Attempt: {}",
-                            io_err,
+                            "DuckDB failure encountered: {}. Retrying after recreating connection. Attempt: {}",
+                            duckdb_err,
                             attempt
                         );
                         state.recreate_db(database_id).await?;
                         continue;
                     }
                 }
 
+                tracing::error!("+++ ERROR {:?}", err);
                 return Err(AppError::Error(err));
             }
             Err(err) => return Err(err),