fix: Don't consolidate aggregated and non-aggregated queries without a groupby #479
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
QueryConsolidator
, make sureSELECT x FROM table
is not consolidated withSELECT count() FROM table
since the aggregation in the latter query implies an implicit grouping which the former doesn't.Implemented the fix by adding a GROUP BY * to the query's consolidation key where aggregates are present in the select.
Fixes #478