no default shell in composite actions #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious why the check was skipped? |
scottyhq
commented
Jan 6, 2022
|
Should we also add the cookiecutter directory to the |
Good call. Might run into issues with the odd folder name |
jomey
reviewed
Jan 6, 2022
JessicaS11
reviewed
Jan 6, 2022
|
I think this is good to go now, thanks for the helpful comments! I wouldn't be surprised if it requires one more followup to get CI fully working again. |
jomey
approved these changes
Jan 7, 2022
|
@JessicaS11 - Are you OK with merging this and follow up with another PR to fine-tune the trigger actions? |
JessicaS11
approved these changes
Jan 7, 2022
jomey
pushed a commit
that referenced
this pull request
Apr 6, 2022
Since scientific Python packages following NEP29 should have deprecated Python 3.7 as of 26 Dec 2021.
jomey
pushed a commit
that referenced
this pull request
Apr 6, 2022
Since scientific Python packages following NEP29 should have deprecated Python 3.7 as of 26 Dec 2021.
jomey
pushed a commit
that referenced
this pull request
Apr 6, 2022
Since scientific Python packages following NEP29 should have deprecated Python 3.7 as of 26 Dec 2021.
jomey
pushed a commit
that referenced
this pull request
Apr 6, 2022
Since scientific Python packages following NEP29 should have deprecated Python 3.7 as of 26 Dec 2021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #42
Any 'run' command in github actions needs the shell type (bash) specified
actions/runner#646 (comment)
Also need to pass secrets as inputs (https://stackoverflow.com/questions/70098241/using-secrets-in-composite-actions-github)