[oneDPL] Improve requirements for iterator source types #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akukanov
reviewed
Aug 12, 2024
akukanov
reviewed
Aug 16, 2024
akukanov
reviewed
Aug 16, 2024
akukanov
approved these changes
Aug 20, 2024
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
…ike type (We would need to require that the reversed iterator satisfies legacy random access iterator, but we get that for free as reverse iterator does not modify that trait.) Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
danhoeflinger
force-pushed
the
dev/dhoeflin/iterator_restrictions
branch
from
ab0dc05
to
d00d244
Compare
Signed-off-by: Dan Hoeflinger <dan.hoeflinger@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the specification of
permutation_iterator,zip_iterator, andtransform_iteratorby adding requirements for their source iterator types.The source iterator type for each of these iterators share the same requirements, for which a name requirement
ValidParallelIteratorSourcehas been defined. There may be a better or more concise name for this requirement.permutation_iteratorhas a typeIndexMapwhich has a modified set of requirements fromValidParallelIteratorSource, because some types likezip_iteratoranddiscard_iteratordo not make sense in this setting. Additionally,IndexMapcan instead be a functor which transforms consecutive indices into a map. In practice, one implementation of this functionality would be to use atransform_iterator<counting_iterator, IndexMap>to provide the iterator serving as theIndexMapin a similar way to other incomingIndexMapiterators.