Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDPL] Clarify the semantics of dpl::begin/end return type #570

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

akukanov
Copy link
Contributor

The patch updates the description for buffer wrappers (dpl::begin/end function) to clarify the semantics of the type they return.
It also addresses #482

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, optional variable name change.

akukanov and others added 3 commits October 9, 2024 16:21
Co-authored-by: Ruslan Arutyunyan <ruslan.arutyunyan@intel.com>
Copy link
Contributor

@rarutyun rarutyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small edit suggestion above, this LGTM.

@akukanov akukanov merged commit 192af07 into uxlfoundation:main Oct 10, 2024
3 checks passed
@akukanov akukanov deleted the pseudo-iter-comparison branch October 10, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants