Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneMKL][spblas] Add sorted_by_rows property #583

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

Rbiessy
Copy link
Contributor

@Rbiessy Rbiessy commented Sep 23, 2024

Following the discussion in oneapi-src/oneMKL#527 (comment) I suggest to introduce the sorted_by_rows property.

Note that this section already specifies that the default state of COO format is unsorted.

See compiled html page: html.zip

@Rbiessy
Copy link
Contributor Author

Rbiessy commented Sep 26, 2024

Update the table to fix #588

New html doc: docs.zip

Comment on lines 55 to 56
- Guarantees that the indices are sorted by row then by column in
ascending order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Guarantees that the indices are sorted by row then by column in
ascending order.
- Guarantees that the indices are sorted by rows then by columns
within rows in ascending order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in eef74a3

Copy link
Contributor

@gajanan-choudhary gajanan-choudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rbiessy Rbiessy merged commit d742a1b into uxlfoundation:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants