Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDPL] Add requirements to header files and specification version macro #591

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

akukanov
Copy link
Contributor

No description provided.

Copy link
Contributor

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small suggested changed in wording, otherwise this looks good to me.

source/elements/oneDPL/source/common.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Obviously, we need to resolve the discussion of ONEAPI_SPEC_VERSION vs ONEDPL_SPEC_VERSION, once that is resolved I think this is good to go.

@akukanov
Copy link
Contributor Author

akukanov commented Oct 2, 2024

Obviously, we need to resolve the discussion of ONEAPI_SPEC_VERSION vs ONEDPL_SPEC_VERSION, once that is resolved I think this is good to go.

@danhoeflinger I think the macro name is not the point of the discussion. That question was covered at #561 (comment) and resolved to use library-specific prefixes. The oneMKL team went even further and decided to use domain-specific prefixes - see the code in #561.

So the discussion above is not about naming the macro but about the wording around it.

@danhoeflinger
Copy link
Contributor

danhoeflinger commented Oct 2, 2024

@danhoeflinger I think the macro name is not the point of the discussion. That question was covered at #561 (comment) and resolved to use library-specific prefixes. The oneMKL team went even further and decided to use domain-specific prefixes - see the code in #561.

So the discussion above is not about naming the macro but about the wording around it.

Aha, yes. Understood. Thanks for the pointer to that conversation.

Copy link
Contributor

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you.

@akukanov akukanov merged commit 4ac2613 into uxlfoundation:main Oct 14, 2024
3 checks passed
@akukanov akukanov deleted the expand-general-information branch October 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants