-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneDPL] Add requirements to header files and specification version macro #591
[oneDPL] Add requirements to header files and specification version macro #591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one small suggested changed in wording, otherwise this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Obviously, we need to resolve the discussion of ONEAPI_SPEC_VERSION vs ONEDPL_SPEC_VERSION, once that is resolved I think this is good to go.
@danhoeflinger I think the macro name is not the point of the discussion. That question was covered at #561 (comment) and resolved to use library-specific prefixes. The oneMKL team went even further and decided to use domain-specific prefixes - see the code in #561. So the discussion above is not about naming the macro but about the wording around it. |
Aha, yes. Understood. Thanks for the pointer to that conversation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you.
No description provided.