Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDPL] Specify copy and move semantics for device_policy #594

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

akukanov
Copy link
Contributor

@akukanov akukanov commented Oct 3, 2024

Addresses #271.

For this patch, I believe the 7 days review period applies:

7 days for major changes to non-API modifications (such as changes to the documentation of an API)

Copy link
Contributor

@andreyfe1 andreyfe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small wording suggestion, not required for me.

Copy link
Contributor

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@akukanov akukanov merged commit 590a1f0 into uxlfoundation:main Oct 14, 2024
3 checks passed
@akukanov akukanov deleted the policy-copy-move branch October 14, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants