RF: support filtering of const features #1725
Conversation
agorshk
force-pushed
the
dev/agorshk-forest_feature_filtering
branch
2 times, most recently
from
dadb000 to
252980c
Compare
|
/intelci: run |
|
/intelci: restart |
|
/intelci: run |
| @@ -492,7 +492,8 @@ protected: | |||
| _minSamplesSplit(2), | |||
| _minWeightLeaf(0.), | |||
| _minImpurityDecrease(-daal::services::internal::EpsilonVal<algorithmFPType>::get() * x->getNumberOfRows()), | |||
| _maxLeafNodes(0) | |||
| _maxLeafNodes(0), | |||
| _useConstFeatures(false) | |||
There was a problem hiding this comment.
why do you need this variable? you change it nowhere
There was a problem hiding this comment.
I suggest to save this variable, it might be dissuaded to use previous approach in some cases. This variable doesn't changed in any place in this PR.
| _aConstFeatureIdx.reset(maxFeatures * 2); // first maxFeatures elements are used for saving indices of constant features, | ||
| // the other part are used for saving levels of this features | ||
| DAAL_CHECK_MALLOC(_aConstFeatureIdx.get()); | ||
| PRAGMA_IVDEP |
There was a problem hiding this comment.
use memset for _aConstFeatureIdx
services::service_memset_seq<IndexType, cpu>(_aConstFeatureIdx, 0, maxFeatures * 2);There was a problem hiding this comment.
Agree, thanks, it was fixed
| if (_hostApp.isCancelled(s, n)) return nullptr; | ||
|
|
||
| if (!_par.memorySavingMode && !_useConstFeatures) |
There was a problem hiding this comment.
I understand correctly, this code will work for every tree? Why can't we count at the beginning - here, for example?
There was a problem hiding this comment.
This trick of checking "non-const" features effectively works only for "depth-first" build trees strategy. In this case it was put here.
agorshk
force-pushed
the
dev/agorshk-forest_feature_filtering
branch
from
252980c to
23f8c80
Compare
|
/intelci: restart |
|
@Mergifyio rebase |
|
Command
|
napetrov
force-pushed
the
dev/agorshk-forest_feature_filtering
branch
from
23f8c80 to
d6c0661
Compare
|
/intelci: run |
|
@Mergifyio rebase |
|
/intelci: restart |
|
Command
|
Accuracy/MSE and performance were measured and compared on some datasets. Accuracy score was compared on autogluon dataset.
