[bug] fix dpc compilation for OS=win and COMPILER=vc #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the CI oneDAL build example/ build Windows which shows the error. Next I will apply the changes. |
|
/intelci: run |
|
/intelci: run |
icfaust
requested review from
Alexsandruss,
napetrov,
homksei,
ahuber21 and
ethanglaser
as code owners
|
/intelci: run |
Alexandr-Solovev
approved these changes
Jun 5, 2024
|
/intelci: run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is initially to show the issue, with the solution commented out (to replicate the bug). This shows that with VC the $(-Q) setting in the makefile clashes with the definition of the dependency file generation here: https://github.com/oneapi-src/oneDAL/blob/main/dev/make/deps.mk#L115 needed for the icpx/icx compiler in the dpc step.
NOTE: Github CI runner will be removed before converting from draft to PR.
Changes proposed in this pull request: