-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(make): enabling debug build #2946
Merged
Alexandr-Solovev
merged 14 commits into
uxlfoundation:main
from
Alexandr-Solovev:dev/asolovev_debug_linux
Nov 4, 2024
Merged
fix(make): enabling debug build #2946
Alexandr-Solovev
merged 14 commits into
uxlfoundation:main
from
Alexandr-Solovev:dev/asolovev_debug_linux
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanglaser
approved these changes
Oct 24, 2024
/intelci: run |
Alexandr-Solovev
changed the title
fixes for dbg build
DO NOT MERGE: fixes for dbg build
Oct 24, 2024
Alexandr-Solovev
changed the title
DO NOT MERGE: fixes for dbg build
fixes for dbg build
Oct 28, 2024
Alexandr-Solovev
requested review from
Alexsandruss,
napetrov,
homksei and
ahuber21
as code owners
October 28, 2024 17:23
Alexandr-Solovev
requested review from
razdoburdin,
avolkov-intel and
icfaust
as code owners
October 30, 2024 09:09
Alexandr-Solovev
requested review from
david-cortes-intel,
Vika-F and
ethanglaser
October 30, 2024 09:13
Vika-F
reviewed
Oct 30, 2024
makefile
Outdated
-Zl := $(-Zl.$(COMPILER)) | ||
-Zl_DPCPP := $(-Zl.dpcpp) | ||
-DEBC := $(if $(REQDBG),$(-DEBC.$(COMPILER)) -DDEBUG_ASSERT -DONEDAL_ENABLE_ASSERT) -DTBB_SUPPRESS_DEPRECATED_MESSAGES -D__TBB_LEGACY_MODE | ||
-DEBC_DPCPP := $(if $(REQDBG),$(-DEBC.dpcpp) -DDEBUG_ASSERT -DONEDAL_ENABLE_ASSERT) -DTBB_SUPPRESS_DEPRECATED_MESSAGES -D__TBB_LEGACY_MODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that -DTBB_SUPPRESS_DEPRECATED_MESSAGES -D__TBB_LEGACY_MODE
are needed here.
Please check.
Other parts of the PR look good to me.
/intelci: run |
1 similar comment
/intelci: run |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fix for building oneDAL with REQDBG option. The correct opts have been added and aligned with
-DMKL_ILP64
and-Zl
. Also pedantic opts for icx and dpcpp compiler have been updated. Thefno-system-debug
option has been added for the oneDAL build size optimization.Lists of pedantic flags have been updated and aligned for
icx.mkl.32e.mkl
anddpcpp.mk
.Incorrect initialization of
dtrees
structures has been fixed.New flags
-ZL_DPCPP
and-DEBC_DPCPP
have been introduced for avoiding usage ofCOMPILER
flags in compiling and linking dpcpp part.Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance