Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(make): enabling debug build #2946

Merged

Conversation

Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Oct 16, 2024

Description

This PR introduces a fix for building oneDAL with REQDBG option. The correct opts have been added and aligned with -DMKL_ILP64 and -Zl. Also pedantic opts for icx and dpcpp compiler have been updated. The fno-system-debug option has been added for the oneDAL build size optimization.
Lists of pedantic flags have been updated and aligned for icx.mkl.32e.mkl and dpcpp.mk.
Incorrect initialization of dtrees structures has been fixed.
New flags -ZL_DPCPP and -DEBC_DPCPP have been introduced for avoiding usage of COMPILER flags in compiling and linking dpcpp part.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@ethanglaser
Copy link
Contributor

/intelci: run

@Alexandr-Solovev Alexandr-Solovev changed the title fixes for dbg build DO NOT MERGE: fixes for dbg build Oct 24, 2024
@Alexandr-Solovev Alexandr-Solovev changed the title DO NOT MERGE: fixes for dbg build fixes for dbg build Oct 28, 2024
@Alexandr-Solovev Alexandr-Solovev marked this pull request as ready for review October 28, 2024 17:23
@Alexandr-Solovev Alexandr-Solovev changed the title fixes for dbg build fix(make): enabling debug build Oct 30, 2024
makefile Outdated
-Zl := $(-Zl.$(COMPILER))
-Zl_DPCPP := $(-Zl.dpcpp)
-DEBC := $(if $(REQDBG),$(-DEBC.$(COMPILER)) -DDEBUG_ASSERT -DONEDAL_ENABLE_ASSERT) -DTBB_SUPPRESS_DEPRECATED_MESSAGES -D__TBB_LEGACY_MODE
-DEBC_DPCPP := $(if $(REQDBG),$(-DEBC.dpcpp) -DDEBUG_ASSERT -DONEDAL_ENABLE_ASSERT) -DTBB_SUPPRESS_DEPRECATED_MESSAGES -D__TBB_LEGACY_MODE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that -DTBB_SUPPRESS_DEPRECATED_MESSAGES -D__TBB_LEGACY_MODE are needed here.
Please check.
Other parts of the PR look good to me.

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

1 similar comment
@Alexsandruss
Copy link
Contributor

/intelci: run

@Alexandr-Solovev Alexandr-Solovev merged commit d4cb5f4 into uxlfoundation:main Nov 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants