Fix coverity hits in Classifier, Decision Forest and GBT #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vika-F
changed the title
|
/intelci: run |
Vika-F
requested review from
razdoburdin,
ahuber21,
avolkov-intel,
icfaust,
Alexsandruss,
samir-nasibli and
Alexandr-Solovev
as code owners
| @@ -99,6 +99,7 @@ class DAAL_EXPORT InputIface : public daal::algorithms::Input | |||
| public: | |||
| InputIface(size_t nElements); | |||
| InputIface(const InputIface & other) : daal::algorithms::Input(other) {} | |||
| InputIface & operator=(const InputIface & other) = default; | |||
There was a problem hiding this comment.
Should we also add daal::algorithms::Input(other) as in copy-constructor?
There was a problem hiding this comment.
Default compiler-generated implementation should do this. No need to implement this manually.
I've unified all this kind of copy constructors and assignment operators in this PR to have definitions in .h and default implementations in .cpp files.
|
/intelci: run |
david-cortes-intel
approved these changes
Dec 9, 2024
| @@ -38,6 +38,39 @@ Tree::~Tree() {} | |||
|
|
|||
| ModelImpl::ModelImpl() : _nTree(0) {} | |||
|
|
|||
| ModelImpl::ModelImpl(const ModelImpl & other) | |||
There was a problem hiding this comment.
Perhaps some small tests could be added for the ones with non-default constructors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule of three violations were fixed mostly by adding default implementations or deleting copy constructors and assignment operators.
The default implementations were added into
Parameter,Input,InputIface,Model,ModelImplclasses as they are meant to be copy-assignable and copy-constructible.Non-default implementations of copy constructor and assignment operator were added in GBT
ModelImpland multiclass classifierModelclasses because they contain non-POD members.In the internal classes that do not need to be copyable the copy constructors and assignment operators were deleted.
PR completeness and readability
Testing